[CALCITE-5044] Rewrite numberic constant in the sort to avoid rel_to_sql ambiguity #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojustme
changed the title
wojustme
changed the title
…BY, which some dialects wrongly interpret as a reference to a field When an ORDER BY field turns out to be an integer literal, if the target dialect treats ordinals as field references, RelToRelConverter now generates a character literal instead. All constants have no effect on the sort, and therefore the character literal has the desired effect. Close apache#2749
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Mar 25, 2022
…ich some dialects wrongly interpret as a reference to a field When an ORDER BY field turns out to be an integer literal, if the target dialect treats ordinals as field references, RelToRelConverter now generates a character literal instead. All constants have no effect on the sort, and therefore the character literal has the desired effect. Close apache#2749
aymeric-dispa
pushed a commit
to aymeric-dispa/calcite
that referenced
this pull request
Jul 23, 2022
…ich some dialects wrongly interpret as a reference to a field When an ORDER BY field turns out to be an integer literal, if the target dialect treats ordinals as field references, RelToRelConverter now generates a character literal instead. All constants have no effect on the sort, and therefore the character literal has the desired effect. Close apache#2749
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 11, 2022
…ich some dialects wrongly interpret as a reference to a field When an ORDER BY field turns out to be an integer literal, if the target dialect treats ordinals as field references, RelToRelConverter now generates a character literal instead. All constants have no effect on the sort, and therefore the character literal has the desired effect. Close apache#2749
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 28, 2022
…ich some dialects wrongly interpret as a reference to a field When an ORDER BY field turns out to be an integer literal, if the target dialect treats ordinals as field references, RelToRelConverter now generates a character literal instead. All constants have no effect on the sort, and therefore the character literal has the desired effect. Close apache#2749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite numberic constant in the sort to avoid rel_to_sql ambiguity
of 'SqlConformance#isSortByOrdinal'.
Link to JIRA: https://issues.apache.org/jira/browse/CALCITE-5044