[CALCITE-5553] noFlatteningForInput handles single field structs #3092
Conversation
apilloud
changed the title
apilloud
changed the title
apilloud
force-pushed
the
wrongplan
branch
3 times, most recently
from
bc800cc
to
62031a6
Compare
| // and "SAL" is visible but must be greater than 1000, | ||
| // which is the equivalent of: | ||
| // Same columns as "EMP" amd "EMPNULLABLES", but "DEPTNO" not visible and set to 20 by default | ||
| // and "SAL" is visible but must be greater than 1000, which is the equivalent of: |
There was a problem hiding this comment.
Is it necessary to do this comment reformatting?
There was a problem hiding this comment.
Without the comment reformatting I get the following test failure:
/home/runner/work/calcite/calcite/testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java:79:3:
Method length is 376 lines (max allowed is 370). [MethodLength]
This seemed like the simplest change, but I'm happy to do something else instead.
There was a problem hiding this comment.
I see, then we'd better split this method into smaller ones in a separate issue, and I'm ok for this workaround in this one.
There was a problem hiding this comment.
I've logged CALCITE-5574 for this.
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java
Outdated
Show resolved
Hide resolved
| // and "SAL" is visible but must be greater than 1000, | ||
| // which is the equivalent of: | ||
| // Same columns as "EMP" amd "EMPNULLABLES", but "DEPTNO" not visible and set to 20 by default | ||
| // and "SAL" is visible but must be greater than 1000, which is the equivalent of: |
There was a problem hiding this comment.
I see, then we'd better split this method into smaller ones in a separate issue, and I'm ok for this workaround in this one.
|
Kudos, SonarCloud Quality Gate passed! |
| // and "SAL" is visible but must be greater than 1000, | ||
| // which is the equivalent of: | ||
| // Same columns as "EMP" amd "EMPNULLABLES", but "DEPTNO" not visible and set to 20 by default | ||
| // and "SAL" is visible but must be greater than 1000, which is the equivalent of: |
There was a problem hiding this comment.
I've logged CALCITE-5574 for this.
No description provided.