Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-5593] Support aliases query in Elasticsearch adapters #3120

Closed
wants to merge 1 commit into from
Closed

[CALCITE-5593] Support aliases query in Elasticsearch adapters #3120

wants to merge 1 commit into from

Conversation

coolbeevip
Copy link
Member

@julianhyde
Copy link
Contributor

The commit message will become the release notes. It needs to describe the feature. Currently it doesn't mention that it concerns the Elasticsearch adatper.

@coolbeevip coolbeevip changed the title [CALCITE-5593] Support for search queries using aliases [CALCITE-5593] Support aliases query in Elasticsearch adapters Mar 20, 2023
@coolbeevip
Copy link
Member Author

The commit message will become the release notes. It needs to describe the feature. Currently, it doesn't mention that it concerns the Elasticsearch adapter.

thanks for the reminder, I have fixed the commit message

libenchao
libenchao reviewed Mar 20, 2023
View reviewed changes
...csearch/src/test/java/org/apache/calcite/adapter/elasticsearch/ElasticSearchAdapterTest.java Outdated
@@ -189,6 +191,11 @@ private CalciteAssert.AssertThat calciteAssert() {
.returnsCount(0);
}

@Test void testAlias() {
calciteAssert()
.query("select state, city from elastic.zips_alias");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seems asserting nothing, hence it won't be run actually.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@coolbeevip coolbeevip force-pushed the CALCITE-5593 branch 2 times, most recently from 6a94a07 to ac3b743 Compare March 21, 2023 10:10
@coolbeevip coolbeevip closed this Mar 29, 2023
@coolbeevip coolbeevip reopened this Mar 29, 2023
@libenchao
Copy link
Member

@coolbeevip The CI failed now, it seems that you are using an guava feature which is not available in our oldest supported guava version: 16.0.1

@coolbeevip
Copy link
Member Author

coolbeevip commented Mar 29, 2023 •
edited

@coolbeevip The CI failed now, it seems that you are using an guava feature which is not available in our oldest supported guava version: 16.0.1

Thanks for the tip, I will use Java StreamSupport.stream instead Guava Streams.stream

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

libenchao
libenchao approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@libenchao libenchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, merging. @coolbeevip Thanks for your contribution.

@libenchao libenchao closed this in 1f15d98 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@libenchao libenchao libenchao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@coolbeevip @julianhyde @libenchao