[CALCITE-5786] Update QuidemTest and DiffRepository to write intermediate test files to directories other than build/resources/test. This addresses an incremental builds issue with the tests #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iate test files to directories other than build/resources/test. This addresses an incremental builds issue with the tests
|
Kudos, SonarCloud Quality Gate passed! |
|
The Jira issue has screenshots and more details on the issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing to build/resources/test causes issues with incremental build support, ideally these directories shouldn't be written to once the tests have started.
With this change the intermediate files used by tests are written to other directories in the build folder. These locations are passed to the tests through system properties which are marked internal - so they don't factor into input hash key creation for the tests.
I don't know if there was a specific reason why the files were being written to build/resources/test - I'm assuming it was an oversight. Please review this change with care to ensure there wasn't a reason why the behavior was this way.