Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-5773] Gradle show tasks fails when creating javadocAggregateIncludingTests #3278

Closed
wants to merge 1 commit into from
Closed

[CALCITE-5773] Gradle show tasks fails when creating javadocAggregateIncludingTests #3278

wants to merge 1 commit into from

Conversation

zabetak
Copy link
Contributor

@zabetak zabetak commented Jun 23, 2023

  1. Exclude "bom" project from the javadoc aggregation since it does not have "main" and "test" objects causing "tasks" to fail.

  2. Include "tasks" when building with newest & oldest JDK in CI to ensure it remains functional.

@zabetak
[CALCITE-5773] Gradle show tasks fails when creating javadocAggregate…
1526c29 
…IncludingTests

1. Exclude "bom" project from the javadoc aggregation since it does not
have "main" and "test" objects causing "tasks" to fail.

2. Include "tasks" when building with newest & oldest JDK in CI to
ensure it remains functional.
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

NobiGo
NobiGo approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@NobiGo NobiGo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zabetak zabetak closed this in 2baf23b Jun 25, 2023
@zabetak zabetak deleted the fix-gradle-tasks branch June 25, 2023 08:43
JingDas pushed a commit to JingDas/calcite that referenced this pull request Jun 25, 2023
@zabetak @JingDas05
[CALCITE-5773] Gradle show tasks fails when creating javadocAggregate…
d4fcc4e 
…IncludingTests

1. Exclude "bom" project from the javadoc aggregation since it does not
have "main" and "test" objects causing "tasks" to fail.

2. Include "tasks" when building with newest & oldest JDK in CI to
ensure it remains functional.

Close apache#3278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@libenchao libenchao libenchao left review comments

@NobiGo NobiGo NobiGo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zabetak @libenchao @NobiGo