[CALCITE-5939] Support mv rewrite between join types #3381
Conversation
suibianwanwank
force-pushed
the
feature_expand_join_rewrite
branch
from
e35afdc
to
73fe67f
Compare
| import static org.apache.calcite.plan.expand.SubstitutionRuleUtils.tryMergeParentCalcAndGenResult; | ||
|
|
||
| /** | ||
| * Enhancements to joinOnLeftCalcToJoinUnifyRule. |
There was a problem hiding this comment.
Can you make the comments more detailed? It's better to include examples in the comments so that others can understand them easily,the other classes are the same
|
Please check you PR workflow,there are many failures. |
| /** | ||
| * Enhancements to joinOnRightCalcToJoinUnifyRule. | ||
| */ | ||
| public class ExpandJoinOnRightCalcToJoinUnifyRule |
There was a problem hiding this comment.
ExpandJoinOnRightCalcToJoinUnifyRule,ExpandJoinOnLeftCalcToJoinUnifyRule,ExpandJoinOnCalcToJoinUnifyRule,What is the difference between them？
There was a problem hiding this comment.
You can see that there are prototypes of these three rules in the rules that already exist in SubstitutionVisitor, because the unifyRule is an adaptation of the operator to the operator level, so different input structures of Join are treated differently, which you can also reflect in tests
For example, the following two SQL statements correspond to JoinOnLeftCalc and JoinOnRightCalc, respectively
select A.empid, A.deptno, depts.deptno from (select empid, deptno from emps where deptno > 10) A join depts on A.deptno = depts.deptno ;
select A.empid, A.deptno, depts.deptno from depts join (select empid, deptno from emps where deptno > 10) A on depts.deptno = A.deptno ;
There was a problem hiding this comment.
Thank you for your attention to this issue, after some time to verify, I refactored this part of the code, optimized some processes and added more comments, you can reread this code if you're interested @LakeShen
ok，I will fix it in these days |
suibianwanwank
force-pushed
the
feature_expand_join_rewrite
branch
from
73fe67f
to
aab3e8d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
suibianwanwank
force-pushed
the
feature_expand_join_rewrite
branch
2 times, most recently
from
6a4eb9d
to
b88ad8e
Compare
suibianwanwank
force-pushed
the
feature_expand_join_rewrite
branch
from
b88ad8e
to
9ff973a
Compare
|
suibianwanwank
changed the title
No description provided.