Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-5952] SemiJoinJoinTransposeRule should check if JoinType supports pushing predicates into its inputs #3407

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[CALCITE-5952] SemiJoinJoinTransposeRule should check if JoinType supports pushing predicates into its inputs #3407

merged 1 commit into from
Sep 6, 2023

Conversation

LeonidChistov
Copy link
Contributor

@LeonidChistov LeonidChistov commented Sep 4, 2023 •
edited

@LeonidChistov LeonidChistov force-pushed the calcite-5952 branch 4 times, most recently from a8626be to 8fb9ff9 Compare September 4, 2023 08:56
@rubenada rubenada self-assigned this Sep 4, 2023
@rubenada rubenada added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Sep 4, 2023
@rubenada rubenada changed the title [CALCITE-5952] Semi-Join incorrectly reordered with Left-Join by SemiJoinJoinTransposeRule [CALCITE-5952] SemiJoinJoinTransposeRule should check if JoinType supports pushing predicates into its inputs Sep 4, 2023
@rubenada
Copy link
Contributor

rubenada commented Sep 4, 2023

Thanks for your reactivity @LeonidChistov !
LGTM
I'll merge in 24-48h if no other remark appears.

@rubenada
Copy link
Contributor

rubenada commented Sep 6, 2023

@LeonidChistov sorry to bother you, it seems due to a recent force push on Calcite main, the PR now shows many unrelated commits; could you please rebase to latest main?

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@LeonidChistov
Copy link
Contributor Author

@rubenada Done.

@rubenada rubenada merged commit d667123 into apache:main Sep 6, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenada rubenada rubenada left review comments

Assignees

@rubenada rubenada

Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Milestone
No milestone
2 participants
@LeonidChistov @rubenada