Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6030] DATE_PART is not handled by the RexToLixTranslator #3446

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[CALCITE-6030] DATE_PART is not handled by the RexToLixTranslator #3446

merged 1 commit into from
Oct 20, 2023

Conversation

mihaibudiu
Copy link
Contributor

Please note that running this test requires #3445 to be merged first.

@mihaibudiu mihaibudiu mentioned this pull request Sep 28, 2023
Closed
@mihaibudiu
[CALCITE-6030] DATE_PART is not handled by the RexToLixTranslator
298dd11 
Signed-off-by: Mihai Budiu <mbudiu@gmail.com>
@mihaibudiu
Copy link
Contributor Author

I have reworked this bugfix so that it can be merged right away, and we can debate #3445 separately.

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

libenchao
libenchao approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@libenchao libenchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@libenchao libenchao merged commit e3b5028 into apache:main Oct 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@libenchao libenchao libenchao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mihaibudiu @libenchao