[CALCITE-6047] Release Calcite 1.36.0 #3505

libenchao · 2023-11-06T06:57:29Z

No description provided.

rubenada · 2023-11-06T08:34:17Z

site/_docs/history.md

 #### Build and test suite
 {: #build-1-36-0}

+* [<a href="https://issues.apache.org/jira/browse/CALCITE-5921">CALCITE-5921</a>]
+ `SqlOperatorFixture.checkFails` and `checkAggFails` don't check runtime failure (follow-up)


minor: no need to mention this "follow-up", it's enough to mention this ticket only once (on the next line).

zabetak

Looks good, thanks for putting this together @libenchao ! Only minor comments that can be addressed after the release.

zabetak · 2023-11-06T08:31:28Z

site/_docs/history.md

+
+Among other new features, it's worth highlighting the adding of 30 new SQL functions in various libraries such as BigQuery and Spark, many improvements hardening `TABLESAMPLE` , and also the following features:
+* [<a href="https://issues.apache.org/jira/browse/CALCITE-5615">CALCITE-5615</a>]
+ Run SQL Logic Test suite using Calcite's HSQLDB JDBC adapter


This is not a new feature but a test improvement. Not sure it fits here.

I have the same feeling when I added it here, I thought it is a major work that I wanted to highlight it. How about adding a line below 'highlighting new features' paragraph like:

In addition to new features, it's also worth highlighting the integrating of SQL Logic Test suite.

+1 It's a major improvement to the test suite and therefore in my opinion deserves to be mentioned as a feature.

zabetak · 2023-11-06T08:36:33Z

site/_docs/history.md

+* [<a href="https://issues.apache.org/jira/browse/CALCITE-6022">CALCITE-6022</a>]
+ Support `CREATE TABLE ... LIKE DDL` in server module
+* [<a href="https://issues.apache.org/jira/browse/CALCITE-6050">CALCITE-6050</a>]
+ Add interface `ImmutablePairList`


Should this be in API changes and minor enhancements section?

zabetak · 2023-11-06T08:39:59Z

site/_docs/history.md

+* [<a href="https://issues.apache.org/jira/browse/CALCITE-6052">CALCITE-6052</a>]
+ `SqlImplementor` writes `REAL`, `FLOAT`, or `DOUBLE` literals as `DECIMAL` literals
+* [<a href="https://issues.apache.org/jira/browse/CALCITE-6041">CALCITE-6041</a>]
+ `MAP` sub-query gives NullPointerException


Backticks around NullPointerException?

zabetak · 2023-11-06T08:41:21Z

site/_docs/history.md

+* Add various lint checks
+* Code style: lint


Consider moving them to "Build and test suite" section.

zabetak · 2023-11-06T08:42:19Z

site/_docs/history.md

+* [<a href="https://issues.apache.org/jira/browse/CALCITE-5732">CALCITE-5732</a>]
+ `EnumerableHashJoin` and `EnumerableMergeJoin` on composite key return rows matching condition `NULL = NULL`
+* [<a href="https://issues.apache.org/jira/browse/CALCITE-5967">CALCITE-5967</a>]
+ UnsupportedOperationException while implementing a call that requires a special collator


Backticks around UnsupportedOperationException?

zabetak · 2023-11-06T08:44:36Z

site/_docs/history.md

+* [<a href="https://issues.apache.org/jira/browse/CALCITE-5837">CALCITE-5837</a>]
+ `RexUtil#pullFactors` output's order should be deterministic even when the RexNode kind is `OR`
+* [<a href="https://issues.apache.org/jira/browse/CALCITE-5877">CALCITE-5877</a>]
+ AssertionError during `MOD` operation if result scale is greater than maximum numeric scale


Backtickts around AssertionError?

zabetak · 2023-11-06T08:46:42Z

site/_docs/history.md

+ `SqlOperatorTest` using `safeParameters` are not using overridable fixture
+* [<a href="https://issues.apache.org/jira/browse/CALCITE-6014">CALCITE-6014</a>]
+ Create a `SqlOperatorFixture` that parses, unparses, and then parses again before executing
+* [MINOR] Incorrect test fixture used by `SqlOperatorTest.testLeastFunc`


Remove [MINOR] from the message since it doesn't add much to the description. When editing the release notes we have the liberty to change and improve the summary if necessary.

zabetak · 2023-11-06T08:47:04Z

site/_docs/history.md

+ Run SQL Logic Test suite using Calcite's HSQLDB JDBC adapter
+* [<a href="https://issues.apache.org/jira/browse/CALCITE-5909">CALCITE-5909</a>]
+ `SqlParserTest.testNoUnintendedNewReservedKeywords` fails in IDE while passes in command line
+* [MINOR] Refactor `RelDataTypeSystemTest` to use test fixture


Remove [MINOR].

zabetak · 2023-11-06T08:48:29Z

site/_docs/history.md

+ `ARRAY_TO_STRING` function should return `NULL` if its `nullValue` argument is `NULL`
+* [<a href="https://issues.apache.org/jira/browse/CALCITE-6075">CALCITE-6075</a>]
+ Site: Cloning source code from GitHub using git protocol fails
+* [MINOR] Add example for `MAP` type in reference docs


Remove [MINOR].

zabetak · 2023-11-06T08:49:19Z

site/_docs/history.md

+ Documentation for `CREATE TYPE` is incorrect
+* Remove mentions of binary distribution from README
+* Update broken link in `RelMetadataProvider` Javadoc
+* Minor: the parameter names of `SqlTypeMappingRules.Builder#add` are misleading


Remove Minor:

libenchao

@zabetak @rubenada Thanks for your review, I've addressed and replied to your comments.

libenchao · 2023-11-06T10:53:11Z

site/_docs/history.md

+
+Among other new features, it's worth highlighting the adding of 30 new SQL functions in various libraries such as BigQuery and Spark, many improvements hardening `TABLESAMPLE` , and also the following features:
+* [<a href="https://issues.apache.org/jira/browse/CALCITE-5615">CALCITE-5615</a>]
+ Run SQL Logic Test suite using Calcite's HSQLDB JDBC adapter


I have the same feeling when I added it here, I thought it is a major work that I wanted to highlight it. How about adding a line below 'highlighting new features' paragraph like:

In addition to new features, it's also worth highlighting the integrating of SQL Logic Test suite.

julianhyde · 2023-11-07T00:17:59Z

site/_docs/history.md

+Zhengqiang Duan,
+Zoltan Haindrich,
+zoovwang.
+


I'm tempted to write (and commit) a script to generate the 'contributors to this release' section. It could be a sed script that converts email addresses into people's real names.

When I handled the contributor name, there were four cases:

the name in commit message

the name on Github profile

the name in Jira account

fails all above ways, I'll ask the contributor for it

Do you mean we can add a script to generate names just from the first case?

Turns out that git's .mailmap file can do a lot of this. I've logged CALCITE-6125 to add a .mailmap.

julianhyde · 2023-11-07T00:20:32Z

site/_docs/history.md

+ Support `LIMIT start, ALL` in MySQL conformance, equivalent to `OFFSET start`
+* [<a href="https://issues.apache.org/jira/browse/CALCITE-5889">CALCITE-5889</a>]
+ Add the RelRule that converts `Minus` into `UNION ALL..GROUP BY...WHERE`
+


s/the RelRule/a RelRule/

… paragraph

sonarcloud · 2023-11-07T05:21:44Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[CALCITE-6047] Release Calcite 1.36.0

c1e4805

rubenada reviewed Nov 6, 2023

View reviewed changes

zabetak reviewed Nov 6, 2023

View reviewed changes

libenchao commented Nov 6, 2023

View reviewed changes

Address comments

dadc1bc

libenchao force-pushed the releasing-note-for-1.36.0 branch from 3c02637 to dadc1bc Compare November 6, 2023 11:20

mihaibudiu approved these changes Nov 6, 2023

View reviewed changes

julianhyde reviewed Nov 7, 2023

View reviewed changes

Change "the RelRule" to "a RelRule", and move logic tests to separate…

a78b9df

… paragraph

libenchao closed this in 0be8eae Nov 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CALCITE-6047] Release Calcite 1.36.0 #3505

[CALCITE-6047] Release Calcite 1.36.0 #3505

libenchao commented Nov 6, 2023

rubenada Nov 6, 2023

zabetak left a comment

zabetak Nov 6, 2023

libenchao Nov 6, 2023 •

edited

julianhyde Nov 7, 2023 •

edited

zabetak Nov 6, 2023

zabetak Nov 6, 2023

zabetak Nov 6, 2023

zabetak Nov 6, 2023

zabetak Nov 6, 2023

zabetak Nov 6, 2023

zabetak Nov 6, 2023

zabetak Nov 6, 2023

zabetak Nov 6, 2023

libenchao left a comment

libenchao Nov 6, 2023 •

edited

julianhyde Nov 7, 2023

libenchao Nov 7, 2023

julianhyde Nov 17, 2023

julianhyde Nov 7, 2023

sonarcloud bot commented Nov 7, 2023

[CALCITE-6047] Release Calcite 1.36.0 #3505

[CALCITE-6047] Release Calcite 1.36.0 #3505

Conversation

libenchao commented Nov 6, 2023

Choose a reason for hiding this comment

zabetak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

libenchao Nov 6, 2023 • edited

Choose a reason for hiding this comment

julianhyde Nov 7, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

libenchao left a comment

Choose a reason for hiding this comment

libenchao Nov 6, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Nov 7, 2023

libenchao Nov 6, 2023 •

edited

julianhyde Nov 7, 2023 •

edited

libenchao Nov 6, 2023 •

edited