[CALCITE-6098] Update LICENSE and NOTICE for Jekyll website template #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
mihaibudiu
approved these changes
Jan 11, 2024
XuQianJin-Stars
approved these changes
Jan 13, 2024
The NOTICE file contains the following statement: ``` The web site includes files generated by Jekyll. ``` However, there is nothing in the LICENSE of Jekyll, that requires such attribution. According to the instructions of composing the NOTICE file for ASF projects we shouldn't add anything in there that is not legally required. The files comprisings the template of the web site i.e., site/_includes, site/_layouts, site/_sass, site/css were copied and slightly adapted from the ORC repository, which in turn copied the template from the Jekyll repository. There have been various small additions in the orignal template (some .html files under the respective directories are completely new) which could potentially licensed under AL2 but it would complicate the LICENSE documentation without significant gain. It's better if the consumers of the source distribution know that this is a Jekyll template licensed under MIT.
zabetak
changed the title
|
@mihaibudiu @XuQianJin-Stars After discussion under the JIRA I took quite a different approach in this PR (thus the rebase). Letting you know in case you want to reconsider your approval. |
|
Licensing and the way it should be surfaced in documentation is not my forte, but the changes look fine otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NOTICE file contains the following statement:
However, there is nothing in the LICENSE of Jekyll, that requires such attribution.
According to the instructions of composing the NOTICE file for ASF projects we shouldn't add anything in there that is not legally required.
The files comprisings the template of the web site i.e.,
site/_includes,
site/_layouts,
site/_sass,
site/css
were copied and slightly adapted from the ORC repository, which in turn copied the template from the Jekyll repository. There have been various small additions in the orignal template (some .html files under the respective directories are completely new) which could potentially licensed under AL2 but it would complicate the LICENSE documentation without significant gain. It's better if the consumers of the source distribution know that this is a Jekyll template licensed under MIT.