[CALCITE-6168] RexExecutor can throw during compilation #3588
Conversation
|
Maybe I should refine the catch block to catch fewer exceptions. |
|
| @@ -1418,6 +1418,14 @@ protected static Calendar getCalendarNotTooNear(int timeUnit) { | |||
| } | |||
| } | |||
|
|
|||
| /** Test case for | |||
| * <a href="https://issues.apache.org/jira/browse/CALCITE-6168">[CALCITE-6168] | |||
There was a problem hiding this comment.
I don't think this test belongs here, it's not a test case for a specific operator. I think there is a test class called RexExecutorTest that might be better.
mihaibudiu
force-pushed
the
issue6168
branch
from
6e9a337
to
38f851b
Compare
|
Thank you @tanclary for the review, I have pushed one more commit which addresses your suggestion. |
|
Can someone please review this PR which fixes a bug? |
| ise = (IllegalStateException) x; | ||
| break; | ||
| } | ||
| if (x.getCause() == x) { |
There was a problem hiding this comment.
Is this just to prevent SO?
There was a problem hiding this comment.
I have seen this pattern used elsewhere in this function, so I have followed it. I am not sure whether a Throwable can have itself as a cause. It looks like the Java APIs make that possible, since you can create a Throwable and assign a cause to it later using initCause.
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
No description provided.