Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-6174] Upgrade gradle from 7.6.1 to 8.7 #3591

Closed
wants to merge 1 commit into from

Conversation

snuyanzin
Copy link
Contributor

@snuyanzin snuyanzin commented Dec 22, 2023

The PR is to bump Gradle from 7.6.1 to 8.7 as a required step before starting activity to support java 20+

gradle.properties Outdated Show resolved Hide resolved
@snuyanzin snuyanzin force-pushed the calcite6174 branch 2 times, most recently from 3133fa5 to db44500 Compare December 22, 2023 11:52
@snuyanzin snuyanzin force-pushed the calcite6174 branch 2 times, most recently from 5c52787 to 928491a Compare May 19, 2024 08:55
@snuyanzin snuyanzin changed the title [CALCITE-6174] Upgrade gradle from 7.6.1 to 8.5 [CALCITE-6174] Upgrade gradle from 7.6.1 to 8.7 May 19, 2024
Jenkinsfile Show resolved Hide resolved
Copy link
Member

@caicancai caicancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local test successful

Copy link
Contributor

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, left some minor comments/questions.

Jenkinsfile Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
core/build.gradle.kts Outdated Show resolved Hide resolved
@snuyanzin snuyanzin force-pushed the calcite6174 branch 3 times, most recently from 8e4e3d3 to 94daed8 Compare May 23, 2024 11:45
Gradle wrapper task is removed since now
for the same functionality there could be used
`./gradlew wrapper --gradle-version=<new_gradle_version> --gradle-distribution-sha256-sum=<distribution-sum>`

Dependencies bumped
gradle rat plugin from 0.7.0 to 0.8.1
jmh plugin from 0.5.3 to 0.7.2
jacoco from 0.8.10 to 0.8.12
kotlin from 1.7.10 to 1.9.22

sonarplugin version to use in sonarqube is now 4.4.1.3373
We still need to keep 3.x version in gradle.properties
to make it compilable with jdk8
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

snuyanzin added a commit to snuyanzin/calcite that referenced this pull request May 24, 2024
Gradle wrapper task is removed since now
for the same functionality there could be used
`./gradlew wrapper --gradle-version=<new_gradle_version> --gradle-distribution-sha256-sum=<distribution-sum>`

Dependencies bumped
gradle rat plugin from 0.7.0 to 0.8.1
jmh plugin from 0.5.3 to 0.7.2
jacoco from 0.8.10 to 0.8.12
kotlin from 1.7.10 to 1.9.22

Sonarplugin version to use in sonarqube is now 4.4.1.3373
There is still need to keep 3.x version in gradle.properties
to make it compilable with jdk8

Replaced deprecated `capitalize`, `html.isEnabled`, `xml.isEnabled`,
`JavaPluginConvention` and `buildDir` in `build.gradle.kts` files

Close apache#3591
github-actions bot pushed a commit to snuyanzin/calcite that referenced this pull request May 24, 2024
Gradle wrapper task is removed since now
for the same functionality there could be used
`./gradlew wrapper --gradle-version=<new_gradle_version> --gradle-distribution-sha256-sum=<distribution-sum>`

Dependencies bumped
gradle rat plugin from 0.7.0 to 0.8.1
jmh plugin from 0.5.3 to 0.7.2
jacoco from 0.8.10 to 0.8.12
kotlin from 1.7.10 to 1.9.22

Sonarplugin version to use in sonarqube is now 4.4.1.3373
There is still need to keep 3.x version in gradle.properties
to make it compilable with jdk8

Replaced deprecated `capitalize`, `html.isEnabled`, `xml.isEnabled`,
`JavaPluginConvention` and `buildDir` in `build.gradle.kts` files

Close apache#3591
@snuyanzin snuyanzin closed this in d274429 May 24, 2024
github-actions bot pushed a commit that referenced this pull request May 24, 2024
Gradle wrapper task is removed since now
for the same functionality there could be used
`./gradlew wrapper --gradle-version=<new_gradle_version> --gradle-distribution-sha256-sum=<distribution-sum>`

Dependencies bumped
gradle rat plugin from 0.7.0 to 0.8.1
jmh plugin from 0.5.3 to 0.7.2
jacoco from 0.8.10 to 0.8.12
kotlin from 1.7.10 to 1.9.22

Sonarplugin version to use in sonarqube is now 4.4.1.3373
There is still need to keep 3.x version in gradle.properties
to make it compilable with jdk8

Replaced deprecated `capitalize`, `html.isEnabled`, `xml.isEnabled`,
`JavaPluginConvention` and `buildDir` in `build.gradle.kts` files

Close #3591
@snuyanzin
Copy link
Contributor Author

Thanks a lot for your feedback @zabetak , @caicancai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants