-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-6174] Upgrade gradle from 7.6.1 to 8.7 #3591
Conversation
3133fa5
to
db44500
Compare
5c52787
to
928491a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local test successful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, left some minor comments/questions.
8e4e3d3
to
94daed8
Compare
Gradle wrapper task is removed since now for the same functionality there could be used `./gradlew wrapper --gradle-version=<new_gradle_version> --gradle-distribution-sha256-sum=<distribution-sum>` Dependencies bumped gradle rat plugin from 0.7.0 to 0.8.1 jmh plugin from 0.5.3 to 0.7.2 jacoco from 0.8.10 to 0.8.12 kotlin from 1.7.10 to 1.9.22 sonarplugin version to use in sonarqube is now 4.4.1.3373 We still need to keep 3.x version in gradle.properties to make it compilable with jdk8
|
Gradle wrapper task is removed since now for the same functionality there could be used `./gradlew wrapper --gradle-version=<new_gradle_version> --gradle-distribution-sha256-sum=<distribution-sum>` Dependencies bumped gradle rat plugin from 0.7.0 to 0.8.1 jmh plugin from 0.5.3 to 0.7.2 jacoco from 0.8.10 to 0.8.12 kotlin from 1.7.10 to 1.9.22 Sonarplugin version to use in sonarqube is now 4.4.1.3373 There is still need to keep 3.x version in gradle.properties to make it compilable with jdk8 Replaced deprecated `capitalize`, `html.isEnabled`, `xml.isEnabled`, `JavaPluginConvention` and `buildDir` in `build.gradle.kts` files Close apache#3591
Gradle wrapper task is removed since now for the same functionality there could be used `./gradlew wrapper --gradle-version=<new_gradle_version> --gradle-distribution-sha256-sum=<distribution-sum>` Dependencies bumped gradle rat plugin from 0.7.0 to 0.8.1 jmh plugin from 0.5.3 to 0.7.2 jacoco from 0.8.10 to 0.8.12 kotlin from 1.7.10 to 1.9.22 Sonarplugin version to use in sonarqube is now 4.4.1.3373 There is still need to keep 3.x version in gradle.properties to make it compilable with jdk8 Replaced deprecated `capitalize`, `html.isEnabled`, `xml.isEnabled`, `JavaPluginConvention` and `buildDir` in `build.gradle.kts` files Close apache#3591
Gradle wrapper task is removed since now for the same functionality there could be used `./gradlew wrapper --gradle-version=<new_gradle_version> --gradle-distribution-sha256-sum=<distribution-sum>` Dependencies bumped gradle rat plugin from 0.7.0 to 0.8.1 jmh plugin from 0.5.3 to 0.7.2 jacoco from 0.8.10 to 0.8.12 kotlin from 1.7.10 to 1.9.22 Sonarplugin version to use in sonarqube is now 4.4.1.3373 There is still need to keep 3.x version in gradle.properties to make it compilable with jdk8 Replaced deprecated `capitalize`, `html.isEnabled`, `xml.isEnabled`, `JavaPluginConvention` and `buildDir` in `build.gradle.kts` files Close #3591
Thanks a lot for your feedback @zabetak , @caicancai |
The PR is to bump Gradle from 7.6.1 to 8.7 as a required step before starting activity to support java 20+