[CALCITE-6337] Distinguish naked measure inside and outside aggregation #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrkel
force-pushed
the
bk-upstream-configurable-measure-parsing
branch
3 times, most recently
from
85f2fa6
to
310fa01
Compare
tanclary
requested changes
Mar 20, 2024
julianhyde
requested changes
Mar 21, 2024
core/src/main/java/org/apache/calcite/sql/validate/SqlValidator.java
Outdated
Show resolved
Hide resolved
barrkel
changed the title
barrkel
force-pushed
the
bk-upstream-configurable-measure-parsing
branch
from
310fa01
to
a2096ff
Compare
…utside aggregation Split nakedMeasures flag into two flags: - nakedMeasuresInsideAggregatingQuery : allowed in group-by queries - nakedMeasuresOutsideAggregatingQuery : allowed in non-group-by queries The existing nakedMeasures flag is marked as deprecated. Its functionality is equivalent to setting the above two flags to the same value.
barrkel
force-pushed
the
bk-upstream-configurable-measure-parsing
branch
from
a2096ff
to
8f91e6d
Compare
|
This is done. |
tanclary
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Seems like you addressed all of my and @julianhyde 's comments, will merge soon !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split nakedMeasures flag into two flags:
The existing nakedMeasures flag is marked as deprecated. Its functionality is equivalent to setting the above two flags to the same value.