[CALCITE-6285] Function ARRAY_INSERT produces an incorrect result for… #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… negative indices Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
caicancai
reviewed
Apr 2, 2024
| @@ -7008,18 +7008,20 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias functionAlias) { | |||
| "[1, 2, null, 3]", "INTEGER ARRAY NOT NULL"); | |||
| f1.checkScalar("array_insert(array[2, 3, 4], 1, 1)", | |||
| "[1, 2, 3, 4]", "INTEGER NOT NULL ARRAY NOT NULL"); | |||
| f1.checkScalar("array_insert(array[1, 3, 4], -2, 2)", | |||
| f1.checkScalar("array_insert(array[1, 3, 4], -1, 2)", | |||
There was a problem hiding this comment.
I have a question, what will happen if the array length is 5, but I fill in -6? I can test it in spark
There was a problem hiding this comment.
@mihaibudiu Hello！
array_insert(array(1, 3, 4), -4, 2) Spark seems to allow this situation, should we add some test samples?
There was a problem hiding this comment.
the docs say that this is a prepend. there is a test for this below
caicancai
reviewed
Apr 2, 2024
| "[1, 2, 3, 4]", "INTEGER NOT NULL ARRAY NOT NULL"); | ||
| f1.checkScalar("array_insert(array[2, 3, null, 4], -5, 1)", | ||
| f1.checkScalar("array_insert(array[2, 3, null, 4], -6, 1)", |
There was a problem hiding this comment.
Maybe we should write array(), spark does not allow array[]
There was a problem hiding this comment.
these two forms are equivalent
|
@chucheng92 I think we agreed to follow the semantics from the newest version of spark, so if you have no objection I will merge this PR. |
mihaibudiu
added
the
LGTM-will-merge-soon
|
looks good to me. thanks. |
chucheng92
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… negative indices