[CALCITE-6497] Use helper setup method throughout whole ElasticsearchAdapterTest

[timgrein]

I'm working on the LIKE operator for Elasticsearch and noticed that the ElasticSearchAdapterTests are not using a helper method setting up a connection to Elasticsearch consistently, but rather duplicate code sometimes. I want to keep the change separate to not clutter the diff in the LIKE operator PR.

[caicancai]

I'm working on the LIKE operator for Elasticsearch and noticed that the ElasticSearchAdapterTests are not using a helper method setting up a connection to Elasticsearch consistently, but rather duplicate code sometimes. I want to keep the change separate to not clutter the diff in the LIKE operator PR.

I think this change can create a jira case to illustrate it.

I see no need to create jira case mainly just fixing some typos and adding some simple tests

[asolimando]

I'm working on the LIKE operator for Elasticsearch and noticed that the ElasticSearchAdapterTests are not using a helper method setting up a connection to Elasticsearch consistently, but rather duplicate code sometimes. I want to keep the change separate to not clutter the diff in the LIKE operator PR.

I think this change can create a jira case to illustrate it.

I see no need to create jira case mainly just fixing some typos and adding some simple tests

Agreed, please create a Jira ticket @timgrein, direct PRs are for really minor fixes like typos etc., this one it's worth a ticket IMO

EDIT: alternatively, it can be a separate commit in the other PR at review time, when squashed you can add it in the extended comments (I don't think it will make the PR unreadable, it's a pretty mechanical change in a single class)

[timgrein]

Agreed, please create a Jira ticket @timgrein, direct PRs are for really minor fixes like typos etc., this one it's worth a ticket IMO

Gotcha, then I'll create a ticket for this PR and wire it together accordingly!

[timgrein]

Created the ticket https://issues.apache.org/jira/browse/CALCITE-6497 and adjusted the commit message (force-push) to follow the official pattern.

[asolimando]

LGTM

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud