[CALCITE-1684] Set the precision for VARCHAR and VARBINARY to the max… #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imum value when not specified
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Mar 10, 2017
… 1 to "unspecified" (Kevin Liew) If you concatenate two strings and the sum of their precisions is greater than the maximum precision (65,536) the result precision will be unspecified. Close apache#394
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Mar 10, 2017
… 1 to "unspecified" (Kevin Liew) If you concatenate two strings and the sum of their precisions is greater than the maximum precision (65,536) the result precision will be unspecified. Close apache#394
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Mar 10, 2017
… 1 to "unspecified" (Kevin Liew) If you concatenate two strings and the sum of their precisions is greater than the maximum precision (65,536) the result precision will be unspecified. Close apache#394
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Mar 10, 2017
… 1 to "unspecified" (Kevin Liew) If you concatenate two strings and the sum of their precisions is greater than the maximum precision (65,536) the result precision will be unspecified. Close apache#394
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Mar 13, 2017
… 1 to "unspecified" (Kevin Liew) If you concatenate two strings and the sum of their precisions is greater than the maximum precision (65,536 by default on Calcite, but can be overriden in RelDataTypeSystem) the result precision will be unspecified. When casting from unspecified precision to a particular precision, may need to truncate values. Close apache#394
|
@julianhyde @kliewkliew: this change is causing failures in DruidAdapterIT. |
|
@nishantmonu51 the tests passed when I ran |
|
The DruidAdapterIT tests don't get run unless you have a https://github.com/vlsi/calcite-test-dataset VM running. |
|
We don't require committers to run integration tests for every commit. Usually we're OK - but in this case we're not. On the server where I run tests, the mere fact that the VM is running seems to make it more likely that a test run will seg-fault, so I've been less inclined to run it recently. |
ldming
pushed a commit
to ldming/mycalcite
that referenced
this pull request
Sep 13, 2018
… 1 to "unspecified" (Kevin Liew) If you concatenate two strings and the sum of their precisions is greater than the maximum precision (65,536 by default on Calcite, but can be overriden in RelDataTypeSystem) the result precision will be unspecified. When casting from unspecified precision to a particular precision, may need to truncate values. Some unrelated USING tests, and fix typos in method names. Close apache/calcite#394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…imum value when not specified