[CALCITE-1734] Fix select query result parsing with druid 0.9.2 #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In druid 0.9.2 - list of dimensions and metrics was added to druid results Druid PR - apache/druid#2491 Since calcite uses its own parsing logic, this PR fixes the logic to ignore dimensions and metrics from resultset if present. Tested this with both Druid v0.9.1 and v0.9.2
|
👍 Thanks Nishant ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In druid 0.9.2 - list of dimensions and metrics was added to druid
results Druid PR - apache/druid#2491
Since calcite uses its own parsing logic, this PR fixes the logic to
ignore dimensions and metrics from resultset if present.
Tested this with both Druid v0.9.1 and v0.9.2.
Corresponding PR to upgrade test VM to druid 0.9.2 -
vlsi/calcite-test-dataset#19