Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-1873] SqlValidatorImpl: Strip AS when visiting group-by-ordinal. #490

Closed
wants to merge 1 commit into from

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Jul 5, 2017

Otherwise, you could get an error like "Expression 'EMP.EMPNO' is not being grouped"
in the attached test cases.

Otherwise, you could get an error like "Expression 'EMP.EMPNO' is not being grouped"
in the attached test case.
@gianm
Copy link
Contributor Author

gianm commented Jul 5, 2017

This patch is for https://issues.apache.org/jira/browse/CALCITE-1873.

@gianm gianm changed the title SqlValidatorImpl: Strip AS when visiting group-by-ordinal. [CALCITE-1873] SqlValidatorImpl: Strip AS when visiting group-by-ordinal. Jul 5, 2017
julianhyde pushed a commit to julianhyde/calcite that referenced this pull request Jul 6, 2017
… "Expression is not being grouped" error if column has alias

The solution is to ignore column aliases when validating a "GROUP BY
ordinal" query. Otherwise, you get an error like "Expression 'EMP.EMPNO'
is not being grouped" (see test case).

Close apache#490
julianhyde pushed a commit to julianhyde/calcite that referenced this pull request Jul 6, 2017
… "Expression is not being grouped" error if column has alias

The solution is to ignore column aliases when validating a "GROUP BY
ordinal" query. Otherwise, you get an error like "Expression 'EMP.EMPNO'
is not being grouped" (see test case).

Close apache#490
@asfgit asfgit closed this in d4ab1e5 Jul 6, 2017
ldming pushed a commit to ldming/mycalcite that referenced this pull request Sep 13, 2018
… "Expression is not being grouped" error if column has alias

The solution is to ignore column aliases when validating a "GROUP BY
ordinal" query. Otherwise, you get an error like "Expression 'EMP.EMPNO'
is not being grouped" (see test case).

Close apache/calcite#490
7mming7 pushed a commit to Kyligence/calcite that referenced this pull request Jan 23, 2021
… "Expression is not being grouped" error if column has alias

The solution is to ignore column aliases when validating a "GROUP BY
ordinal" query. Otherwise, you get an error like "Expression 'EMP.EMPNO'
is not being grouped" (see test case).

Close apache#490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant