[CALCITE-2462] RexProgramTest: move "rex building" methods to base class #788
+626
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies creating Rex-based input data for tests
…ynamicParam test The test checkSimplifyDynamicParam duplicates existing testSimplifyIsNotNull, however it uses dynamic params, so the test becomes much cleaner.
|
I think this is feature complete. Could I get reviews please? |
…in case expression
This was caused by copy-paste error. Now |
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Aug 26, 2018
This simplifies creating Rex-based input data for tests fixes apache#788
sergeyT2
pushed a commit
to sergeyT2/calcite
that referenced
this pull request
Aug 29, 2018
This simplifies creating Rex-based input data for tests fixes apache#788
sergeyT2
pushed a commit
to sergeyT2/calcite
that referenced
this pull request
Aug 29, 2018
This simplifies creating Rex-based input data for tests fixes apache#788
F21
pushed a commit
to F21/calcite
that referenced
this pull request
Jan 3, 2019
This simplifies creating Rex-based input data for tests fixes apache#788
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
This simplifies creating Rex-based input data for tests fixes apache#788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-2462
This simplifies creating Rex-based input data for tests
Note: it does not alter existing
RexProgramTest, however I did modify a couple of tests to show how new methods would feel.