Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20253: camel-jbang - Add support for jolokia 2.x #133

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

kulagaIA
Copy link
Contributor

@kulagaIA kulagaIA commented Feb 3, 2024

enabled jolokia in platform-http-main

enabled jolokia in platform-http-main
@kulagaIA
Copy link
Contributor Author

kulagaIA commented Feb 3, 2024

wait this needs pr in camel repo to be merged first

@davsclaus
Copy link
Contributor

@kulagaIA we have merged jolokia into main so I think this PR is ready

@kulagaIA kulagaIA marked this pull request as ready for review February 13, 2024 08:57
@kulagaIA
Copy link
Contributor Author

kulagaIA commented Feb 13, 2024

made it mergeable, but mind that this example needs
<dependency>
<groupId>org.apache.camel</groupId>
<artifactId>camel-jolokia</artifactId>
</dependency>
so if separate jolokia module is absent this example will not compile

@davsclaus
Copy link
Contributor

Ah yeah we have jolokia directly now, so camel-jolokia should be removed.

Then later when we have jolokia as pluggable to main-http we can add a dependency back.

You may also want to update the readme file and mention a bit about jolokia and show how to use it a little bit so users can better understand

@davsclaus davsclaus merged commit f50a432 into apache:main Feb 13, 2024
1 check passed
@kulagaIA kulagaIA deleted the camel-jolokia branch February 13, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants