Fix #170: add support for webhook endpoints #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Oct 23, 2019
|
Maybe this should be a customizer ? and maybe in its own artifact |
Not sure.. let me think about it.. If the behavior can be activated only by a trait (and I think it's acceptable), yeah, it's possible to externalize it in a lib with a customizer |
That would be very good for quarkus pov |
lburgazzoli
approved these changes
Oct 23, 2019
|
Minor thing, add the artifact to the bom and to the registry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #170
When
CAMEL_K_WEBHOOK_ACTIONis set toREGISTERorUNREGISTER, the webhook route policy executes the registration/deregistration of all webhooks appearing on the routes and terminates the camel context without starting the routes.This will be used in combination with a new workflow to be implemented in Camel K.