Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a test collecting all *.camelk.yaml files in the repository and validating it against the yaml schema #402

Merged
merged 1 commit into from Jul 16, 2020

Conversation

lburgazzoli
Copy link
Contributor

Fixes #387

Note that there's no '*.camelk.yaml' files

@lburgazzoli lburgazzoli merged commit 2dd373d into apache:master Jul 16, 2020
@lburgazzoli lburgazzoli deleted the github-387 branch July 16, 2020 17:20
@@ -19,7 +19,7 @@
steps:
- aggregate:
strategy-ref: "aggregatorStrategy"
completion-size: 2
completion-size: "2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it changed from a number to a string? is it a bug/limitation in the schema? or is it the example which had a bug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is because the completion size is a string field: https://github.com/apache/camel/blob/c2f5ba87c4173e36e99f6332e44f055572e72d24/core/camel-core-engine/src/main/java/org/apache/camel/model/AggregateDefinition.java#L97

camel does not care much as it is able to convert among types but the type is of course relevant for the schema validation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if needed, it seems to be possible to use multiple primitive type for the schema definition: https://json-schema.org/draft/2019-09/json-schema-core.html#rfc.section.7.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a test collecting all *.camelk.yaml files in the repository and validating it against the yaml schema
3 participants