Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kamelet source/sink component #511

Merged
merged 3 commits into from Sep 30, 2020
Merged

kamelet source/sink component #511

merged 3 commits into from Sep 30, 2020

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Sep 28, 2020 •
edited

Fixes #490
Fixes #500

Release Note

NONE

@lburgazzoli
Copy link
Contributor Author

@davsclaus I've merged your PR and it works fine, thx for your support

Wonder if to have better control over the route template creation process we should add a consumer to the CamelContext::addRouteFromTemplate that is invoked with the result of RouteTemplateDefinition::asRouteDefinition so we can hack the resulting route definition i.e. replace the in/out like in your solution.

@davsclaus
Copy link
Contributor

Yeah @lburgazzoli that is a good idea, if you got the time this morning then you are welcome to fix that - I am in the middle of simple language improvements.

@lburgazzoli
Copy link
Contributor Author

@davsclaus sure I will do it

@lburgazzoli
Copy link
Contributor Author

@nicolaferraro whith this PR, using direct:{{routeId}} won't be supported anymore and willr br replaced by kamelet:source and kamelet:sink

@lburgazzoli lburgazzoli marked this pull request as ready for review September 29, 2020 07:49
@lburgazzoli
Copy link
Contributor Author

@davsclaus opened apache/camel#4313, it is slightly different from the proposal as the definitions are not part of the APIs thus I can't add something meaningful to the camel context.

@lburgazzoli lburgazzoli marked this pull request as draft September 29, 2020 12:40
@lburgazzoli lburgazzoli marked this pull request as ready for review September 29, 2020 15:00
@lburgazzoli lburgazzoli merged commit 979288e into apache:master Sep 30, 2020
@lburgazzoli lburgazzoli deleted the github-490-no-direct branch September 30, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davsclaus davsclaus davsclaus approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sink Kamelet not called kamelet-sink component
3 participants
@lburgazzoli @davsclaus @oscerd