Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quarkus:dev option for running the examples #661

Merged
merged 1 commit into from Apr 20, 2021

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Apr 16, 2021

Based on comment - adding the option to run the examples using:

mvn clean compile quarkus:dev

@lburgazzoli there seems to be a problem with the java example, which doesn't seem to run using the above mentioned command - there seems to be a problem with classloading, the problem is:

2021-04-16 13:51:22,023 ERROR [org.apa.cam.qua.mai.CamelMainRuntime] (Quarkus Main Thread) Failed to start application: org.apache.camel.RuntimeCamelException: org.joor.ReflectException: Compilation error: /MyRoutes.java:17: error: package org.apache.camel.builder does not exist
import org.apache.camel.builder.RouteBuilder;
                               ^
/MyRoutes.java:19: error: cannot find symbol
public class MyRoutes extends RouteBuilder {
                              ^
  symbol: class RouteBuilder
2 errors

I couldn't find the cause of this issue, I can however remove the option from this example, in case there is no easy solution.

Release Note

NONE

@@ -31,6 +31,7 @@
<properties>
<noDeps>true</noDeps>
<quarkus.camel.main.routes-discovery.enabled>false</quarkus.camel.main.routes-discovery.enabled>
<quarkus.package.type>uber-jar</quarkus.package.type>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change required ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily. It is related to the PR I made previously and it effectively reverts the change I introduced, generating uber-jar instead of the fast-jar:

java -jar target/quarkus-app/quarkus-run.jar
java -jar target/camel-k-runtime-example-cron-runner.jar

In case this is undesired, I will remove it from the PR (Apparently I should have separated it in 2 commits in the first place.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use the fast-jar mode as it is the mode we use on camel-k (unless there are known issues)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, will remove this particular type of changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be back to the previous fast-jar usage

@tplevko tplevko marked this pull request as ready for review April 19, 2021 06:25
@lburgazzoli lburgazzoli merged commit 3c2de13 into apache:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants