Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove template and error handler source types #868

Closed
wants to merge 1 commit into from

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Aug 17, 2022

This PR is aimed to explore what we can remove from the camel-k runtime in order to ease the migration of the remaining code in this repo to camel-quarkus and in particular I'm focused on removing the specific source types we have introduced in camel-k long ago.

  1. templates: all the DSLs now have support for routes templates so it is not more needed to have a wrapper that can turn a standard route in a template
  2. error handler: the YAML DSL has now native support for global error handler and as we are using this errror handler source type exclusively to support kamelet bindings, then I think, we can remove the custom source type and use what is provided by the YAML DSL

There is still an issue that is related to the order on which routes are loaded but this can be explored on the apache camel side.

@squakez @davsclaus what do you think ?

Release Note

NONE

@oscerd
Copy link
Contributor

oscerd commented Aug 22, 2022

Do we need this before releasing the next version?

@lburgazzoli
Copy link
Contributor Author

Do we need this before releasing the next version?

No, it needs some adjustments on camel-k ad camel to work properly so, next release maybe

@squakez
Copy link
Contributor

squakez commented Aug 30, 2022

Look good to me. However it will need a rework on how KameletBinding error handlers are managed in Camel K as well (it will be for good as it make it explicit something that is quite hidden right now). As soon as this is ready and merged, we can make some local development/test with the snapshot before the Camel K release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants