Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camel-kafka-connector-generator-maven-plugin: optionally delete submodules not in catalog #149

Closed
valdar opened this issue Apr 24, 2020 · 7 comments
Labels
0.8.0 enhancement New feature or request good first issue issue good to start contributin if you are new to the project
Milestone

Comments

@valdar
Copy link
Member

valdar commented Apr 24, 2020

This needs an exclusion mechanism as well.

See: https://github.com/apache/camel-kafka-connector/blob/master/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/GenerateCamelKafkaConnectorsMojo.java#L170

@valdar valdar added enhancement New feature or request good first issue issue good to start contributin if you are new to the project labels Apr 24, 2020
@svkcemk
Copy link

svkcemk commented Oct 9, 2020

@valdar I wanted to work on this one, I am just starting with camel-kafka-connector would be a good starting point for me !

@KishaniKandasamy
Copy link

Hi @valdar , may I take this task?

@KishaniKandasamy
Copy link

Hi @valdar , Do I need the basic camel knowledge to use the camel-kafka-connector?

@valdar
Copy link
Member Author

valdar commented Dec 12, 2020

To use them, probably not. To contribute to it most probably you do.

@oscerd oscerd added this to the 0.8.0 milestone Jan 13, 2021
@claudio4j
Copy link
Contributor

@valdar just to confirm my understanding about this feature, if a given camel component such as box is not present in camel catalog, the corresponding camel-box-kafka-connector directory should be removed ? Of course there should be a new parameter to control this behavior.

@valdar
Copy link
Member Author

valdar commented Jan 27, 2021

Correct, one should also remove the corresponding module in the pom module list.

@claudio4j
Copy link
Contributor

@valdar can you close this issue ? Thanks.

@valdar valdar closed this as completed Jan 29, 2021
@oscerd oscerd added the 0.8.0 label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.8.0 enhancement New feature or request good first issue issue good to start contributin if you are new to the project
Projects
None yet
Development

No branches or pull requests

5 participants