Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reporting configuration incorrectly handled #835

Closed
orpiske opened this issue Jan 8, 2021 · 3 comments
Closed

Error reporting configuration incorrectly handled #835

orpiske opened this issue Jan 8, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@orpiske
Copy link
Contributor

orpiske commented Jan 8, 2021

The sink connector does not respect the new error reporting configuration from Kafka Connect. As of Kafka 2.6, it seems, we should be using the Errant Record Reporter to ensure that failed records are put into the DLQ.

One way to verify this issue is to use an invalid JMS broker address in the CamelSinkJMSITCase test. This causes a failure in the component which, eventually, leads to a ConnectionException and lost records.

Here's a snippet taken from one of my logs as an example:

Caused by: org.apache.kafka.connect.errors.ConnectException: Exchange delivery has failed!
        at org.apache.camel.kafkaconnector.CamelSinkTask.put(CamelSinkTask.java:185) ~[camel-kafka-connector-0.8.0-SNAPSHOT.jar:0.8.0-SNAPSHOT]
        at org.apache.kafka.connect.runtime.WorkerSinkTask.deliverMessages(WorkerSinkTask.java:560) ~[connect-runtime-2.6.0.jar:?]
        ... 10 more
Caused by: org.apache.camel.ResolveEndpointFailedException: Failed to resolve endpoint: sjms2://ckc.queue due to: javax.jms.JMSException: No Provider scheme specified.

The message is not sent to the DLQ in this case, which violates the expected behavior.

@orpiske orpiske self-assigned this Jan 8, 2021
@orpiske orpiske added the bug Something isn't working label Jan 8, 2021
@orpiske orpiske changed the title Error reporting configuration is not correctly handled Error reporting configuration incorrectly handled Jan 8, 2021
orpiske added a commit to orpiske/camel-kafka-connector that referenced this issue Jan 8, 2021
orpiske added a commit to orpiske/camel-kafka-connector that referenced this issue Jan 8, 2021
@orpiske
Copy link
Contributor Author

orpiske commented Jan 8, 2021

Fixed. Should be available on 0.7.1 and 0.8.0.

@orpiske orpiske closed this as completed Jan 8, 2021
@oscerd
Copy link
Contributor

oscerd commented Jan 20, 2021

@orpiske maybe we could add a little example of this scenario in ckc-examples repository, so we could point user there

@orpiske
Copy link
Contributor Author

orpiske commented Jan 20, 2021

@orpiske maybe we could add a little example of this scenario in ckc-examples repository, so we could point user there

+1. That's a good idea. I will add an example covering this item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants