Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test code fixes for the auto-generated connectors #138

Merged
merged 3 commits into from Apr 22, 2020
Merged

Test code fixes for the auto-generated connectors #138

merged 3 commits into from Apr 22, 2020

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Apr 22, 2020

This fixes a couple of errors in tests and adjust the code to work with the new
auto-generated connectors. It fixes most of the DelegatingClassLoader errors
although one still remain in one scenario: ElasticSearch Rest with Java 8.

@oscerd
Copy link
Contributor

oscerd commented Apr 22, 2020

@orpiske can you fix the codestyle?

orpiske
orpiske commented Apr 22, 2020
View reviewed changes
Copy link
Contributor Author

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hit the send too soon on this one.

tests/src/test/java/org/apache/camel/kafkaconnector/PluginPathHelper.java Outdated Show resolved Hide resolved
@orpiske orpiske force-pushed the fix-delegating-classpath-issues branch from a32a017 to 9b0bf23 Compare April 22, 2020 12:45
@orpiske
Copy link
Contributor Author

orpiske commented Apr 22, 2020

@orpiske can you fix the codestyle?

Done! It should be fine now.

@oscerd
Copy link
Contributor

oscerd commented Apr 22, 2020

Thanks!

@orpiske
Copy link
Contributor Author

orpiske commented Apr 22, 2020

@oscerd @valdar The code is failing because it is looking for the jars and we don't generate them here. I'm going to go back to the code and handle this scenario.

@orpiske orpiske force-pushed the fix-delegating-classpath-issues branch from 9b0bf23 to 6770d9c Compare April 22, 2020 14:04
@oscerd
Copy link
Contributor

oscerd commented Apr 22, 2020

LGTM

@oscerd
Copy link
Contributor

oscerd commented Apr 22, 2020

@valdar is it ok for you?

@orpiske
Copy link
Contributor Author

orpiske commented Apr 22, 2020 •
edited

BTW: to remove the ElasticSearch error, we need to find a way to stop requiring the ConnectRecordValueToMapTransformer class. It does the transformation from the key/pair data format used in ElasticSearch to the record format used by the Kafka message. If we have a way to do this conversion automatically, then we can remove this class and the dependency on the camel-elasticsearch-rest-kafka-connector. This should do the trick of removing the last DelegationClassLoader error on the logs.

Ahhh, no. @valdar gave me an idea that solves the problem without any of this. Just changing the elasticsearch provided dependency to the core one did the trick. Huge thanks for his idea!

@orpiske
Preliminary conversion of the test code
522a6cb 
This converts/adjusts the integration test to to work with the code in the new connectors module. It provides the ground
work for them to use those new set of connectors. It also cleanup most of connectors dependencies as they are not really
required for the test execution/build.
@orpiske
Adjust the PluginPathHelper to return the plugin directories instead …
52a5465 
…of the jar files

- Improved the log information about the duration to initialize the connectors
- Adjust to use the newer properties
- Do log the delegating class messages as it impacts the test execution
- Avoid loading all the jar files into the plugin path causing a long startup delay on the tests
@orpiske
Add one additional parameter to prevent a ClassCastException error wi…
e96566b 
…thin Netty code
@orpiske orpiske force-pushed the fix-delegating-classpath-issues branch from 6770d9c to e96566b Compare April 22, 2020 15:02
valdar
valdar approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@valdar valdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@valdar valdar merged commit 0f33098 into apache:master Apr 22, 2020
This was referenced Apr 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valdar valdar valdar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orpiske @oscerd @valdar