Split the tests in modules per service #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing w/ a Java heap error. I am looking at it. |
orpiske
force-pushed
the
split-integration-tests
branch
from
e49b65d
to
0b49cfc
Compare
This includes: - modifications to normalize package names according to what they are testing - plugin path cleanups so that only the modules in test are loaded - minor log cleanups to avoid repitions and provide sensible defaults since now a log file per module is created - A small fix for not setting the amazon host on the URL test
Related to the known issue apache#260 on Github
orpiske
force-pushed
the
split-integration-tests
branch
from
0b49cfc
to
ca3e4db
Compare
Hooray. The test have passed. |
oscerd
approved these changes
Jun 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed change to solve the dependencies problems discussed on #211.
This changes breaks down the test module into submodules and groups the tests per service or service group (ie.: AWS, SJMS2, ElasticSearch) etc. This way, we can reduce the number of dependencies in test time which would help us find problems such as missing dependencies on the connector.
As a result of this break-down, the logs are generated per module and the plugin.path configuration of the runtime loads only the connector under test.
There is a small increase in test time, as the embedded Kafka and the Kafka Connect Runtime are recycled for every test.