Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-524 Create a source distribution module #577

Merged
merged 2 commits into from Oct 13, 2020
Merged

ISSUE-524 Create a source distribution module #577

merged 2 commits into from Oct 13, 2020

Conversation

cunningt
Copy link
Contributor

oscerd
oscerd requested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one finding.

distribution/src/main/assemblies/source-release.xml Outdated
<assembly>
<id>source-release</id>
<!-- the only thing being done differently here is the base directory -->
<baseDirectory>apache-camel-quarkus-${version}</baseDirectory>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be related to kafkaconnector

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@oscerd
Copy link
Contributor

oscerd commented Oct 13, 2020

Thanks

@oscerd oscerd merged commit 85ac1d3 into apache:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valdar valdar valdar approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cunningt @oscerd @valdar