Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azure-tests #659

Merged
merged 1 commit into from Nov 2, 2020
Merged

Update azure-tests #659

merged 1 commit into from Nov 2, 2020

Conversation

unsortedhashsets
Copy link
Contributor

@unsortedhashsets unsortedhashsets commented Nov 2, 2020 •
edited

Hello, I have prepared some updates for azure-tests (mainly for blob)

  1. fixed endpoint link
  2. Consume function updated with retries loop due the fact of not instant response from real Azure service
  3. Added verification of messages content
  4. Added teardown function
  5. Kindly ask you to review issue camel-azure-storage-queue-kafka-connector: Unknown parameter 'accountName' #409, it seems to me that everything is Ok for now.

orpiske
orpiske approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @unsortedhashsets.

@unsortedhashsets
Copy link
Contributor Author

I am sorry, I have fixed libraries order and deleted not needed libraries also

@orpiske orpiske merged commit 338567c into apache:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpiske orpiske orpiske approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unsortedhashsets @orpiske @oscerd