New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support camel dataformat configuration for marshaller/unmarshaller #816 #855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks a lot. @valdar cc
Can you fix the codestyle? |
|
||
DataFormatDefinition dataformat; | ||
|
||
switch (dataFormatName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this switch case could be avoided by something on the line of context.createDataFormat(dataFormatName)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the general impression that this usecase should have worked already using something like:
camel.dataformat.fhirJson.fhirVersion=R4
camel.dataformat.fhirJson.prettyPrint=true
see https://github.com/apache/camel-kafka-connector/blob/master/core/src/test/java/org/apache/camel/kafkaconnector/DataFormatTest.java#L128
Give me some more time to investigate further.
It should work but it doesn't, if you look at the test, you disable validation and then assert that the validation is enabled. |
Thanks a lot for the effort in seeking the root cause of this and fixing it @luigidemasi ! |
this pr allow the configuration of a dataformat directly in properties file, something like: