Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bean: Use properties instead of property with key and value #1475

Closed
igarashitm opened this issue May 18, 2023 · 1 comment · Fixed by #1488
Closed

Bean: Use properties instead of property with key and value #1475

igarashitm opened this issue May 18, 2023 · 1 comment · Fixed by #1488
Assignees
Milestone

Comments

@igarashitm
Copy link

I found some kamelets are using beans property with key and value style, for example
https://github.com/apache/camel-kamelets/blob/main/kamelets/mysql-sink.kamelet.yaml#L97-L108

But the schema doesn't allow it. RouteTemplateDefinition specifies NamedBeanDefinition for beans
https://github.com/apache/camel/blob/camel-3.20.x/dsl/camel-yaml-dsl/camel-yaml-dsl/src/generated/resources/schema/camel-yaml-dsl.json#LL2621C40-L2621C40

where NamedBeanDefinition has only properties with the type object
https://github.com/apache/camel/blob/camel-3.20.x/dsl/camel-yaml-dsl/camel-yaml-dsl/src/generated/resources/schema/camel-yaml-dsl.json#L339

Once additionalProperties: false is added to the schema (which is on table for doing on Camel4), this could end up with validation error. We'd want to align with schema before it happens.

Cc: @lburgazzoli

@oscerd
Copy link
Contributor

oscerd commented May 25, 2023

Should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants