-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-19386: Support object property on template bean #10205
Conversation
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run. If necessary Apache Camel Committers may access logs and test results in the job summaries! |
Components tested:
|
Also fixed the annotation for `beans` property on TemplatedRouteDefinitionDeserializer and RouteTemplateDefinitionDeserializer to represent what deserializers actually supports in the generated schema
Components tested:
|
hmm components/camel-spring-xml tests doesn't fail for me, can I look at the workflow test log? |
I'll check this PR before noon (CEST). |
yes, this is what I was thinking about and it's ok (in @XmlElement(name = "properties")
@XmlJavaTypeAdapter(BeanPropertiesAdapter.class)
private Map<String, Object> properties; |
This YAML/XML/JAXB consistency is tricky, but finally I got the PR - looks good ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's there something to know in relation to the work ongoin in apache/camel-kamelets#1475
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's there something to know in relation to the work ongoing in apache/camel-kamelets#1475 ?
@oscerd There shouldn't be any problem - this change fixes the schema to allow both property styles, so apache/camel-kamelets#1475 is not mandatory after this. But I think it's still beneficial to do that and align the style with non-template bean on official Kamelets. |
I'll complete the work on that side. Thanks |
Description
Fixes: https://issues.apache.org/jira/browse/CAMEL-19386
Also fixed the annotation for
beans
property on TemplatedRouteDefinitionDeserializer and RouteTemplateDefinitionDeserializer to represent what deserializers actually supports in the generated schemaTarget
camel-3.x
, whereas Camel 4 uses themain
branch)Tracking
Apache Camel coding standards and style
mvn -Pformat,fastinstall install && mvn -Psourcecheck
Cc @lburgazzoli
Hi @grgrzybek , I believe I made it backward compatible for XML DSL for template bean
property
, while it addsproperties
to accept object property like non-template bean style. Hopefully this won't bother your current work...