Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update apiVersion in kamelets to v1 #1562

Closed
claudio4j opened this issue Aug 9, 2023 · 7 comments · Fixed by #1566
Closed

Update apiVersion in kamelets to v1 #1562

claudio4j opened this issue Aug 9, 2023 · 7 comments · Fixed by #1566
Assignees
@apupier

Comments

@claudio4j
Copy link
Contributor

claudio4j commented Aug 9, 2023 •
edited
Loading

  • Change the KameletBinding to Pipe and the apiVersion to v1
@apupier
Copy link
Contributor

apupier commented Aug 9, 2023

I guess KameletsCatalog must be updated too

camel-kamelets/library/camel-kamelets-catalog/src/main/java/org/apache/camel/kamelets/catalog/KameletsCatalog.java

Lines 43 to 45 in 2501406

import org.apache.camel.v1alpha1.Kamelet;
import org.apache.camel.v1alpha1.kameletspec.Definition;
import org.apache.camel.v1alpha1.kameletspec.Template;

@apupier
Copy link
Contributor

apupier commented Aug 10, 2023 •
edited
Loading

Trying to gather what needs to be modified for the move from kameletBinding to Pipe:

@apupier
Copy link
Contributor

apupier commented Aug 10, 2023

Starting to work on this issue (I cannot assign it me)

apupier added a commit to apupier/camel-kamelets that referenced this issue Aug 10, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
ae101ec 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Aug 10, 2023
Merged
@claudio4j
Copy link
Contributor Author

Your proposal sounds good, I think everything is taken care of.
Thank you

@claudio4j
Copy link
Contributor Author

Related to the rename in the camel-kamelets/templates/bindings/camel-k/, afaik there are no external refernces to them, they are self contained examples for reference. There is no harm renaming their names.

apupier added a commit to apupier/camel-kamelets that referenced this issue Aug 14, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
11f367f 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Aug 14, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
248ea58 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Aug 14, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
80305d4 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Aug 14, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
eef02f0 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests
* Updated validator

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Aug 14, 2023
Closed
apupier added a commit to apupier/camel-kamelets that referenced this issue Aug 23, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
80cfead 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests
* Updated validator

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Aug 23, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
f4a2aa7 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests
* Updated validator

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Aug 30, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
93ce4f6 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests
* Updated validator

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 4, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
fd6c5ff 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests
* Updated validator

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 4, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
cebdec8 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests
* Updated validator

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 4, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
6251099 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests
* Updated validator

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 5, 2023
@apupier
Migrate to apiVersion v1 from v1aplha1
6a33274 
fixes apache#1562

* CRDs move apiVersion from camel.apache.org/v1alpha1 to
camel.apache.org/v1
* Migrate from KameletBinding to Pipe
** Rename kind in CRDs
** Renamed KameletBinding examples by changing suffix -bing to -pipe
** Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests
* Updated validator

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 5, 2023
@apupier
Upgrade Camel K CRDs to 2.0.1
35f2390 
Use Kamelet v1 instead of v1alpha1
Keeping KameletBinding and not migrating to Pipes as it is used only in
tests and not yet supported in a released version Camel Jbang

part of apache#1562

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Sep 5, 2023
Merged
oscerd pushed a commit that referenced this issue Sep 5, 2023
@apupier
Upgrade Camel K CRDs to 2.0.1 (#1617)
e11fb60 
Use Kamelet v1 instead of v1alpha1
Keeping KameletBinding and not migrating to Pipes as it is used only in
tests and not yet supported in a released version Camel Jbang

part of #1562

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 6, 2023
@apupier
Migrate from KameletBinding to Pipe
bcb6b76 
fixes apache#1562

* Renamed kind in CRDs
* Renamed KameletBinding examples by changing suffix -binding to -pipe
* Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 6, 2023
@apupier
Migrate from KameletBinding to Pipe
3a777dc 
fixes apache#1562

* Renamed kind in CRDs
* Renamed KameletBinding examples by changing suffix -binding to -pipe
* Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 6, 2023
@apupier
Migrate from KameletBinding to Pipe
6ab65cd 
fixes apache#1562

* Renamed kind in CRDs
* Renamed KameletBinding examples by changing suffix -binding to -pipe
* Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 6, 2023
@apupier
Migrate from KameletBinding to Pipe
f705a47 
fixes apache#1562

* Renamed kind in CRDs
* Renamed KameletBinding examples by changing suffix -binding to -pipe
* Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 6, 2023
@apupier
Migrate from KameletBinding to Pipe
c756273 
fixes apache#1562

* Renamed kind in CRDs
* Renamed KameletBinding examples by changing suffix -binding to -pipe
* Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@davsclaus
Copy link
Contributor

Has all this been done, and if so this can be closed?

@oscerd
Copy link
Contributor

oscerd commented Sep 21, 2023

Not yet we need a release of 4.1.0 or 4.0.1 to complete this issue. There is a PR open waiting for the release. I think it is for yaks test

apupier added a commit to apupier/camel-kamelets that referenced this issue Sep 25, 2023
@apupier
Migrate from KameletBinding to Pipe
f15f942 
fixes apache#1562

* Renamed kind in CRDs
* Renamed KameletBinding examples by changing suffix -binding to -pipe
* Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
oscerd pushed a commit that referenced this issue Sep 26, 2023
@apupier @christophd
Migrate to apiVersion v1 from v1aplha1 (#1566)
e788133 
* Migrate from KameletBinding to Pipe

fixes #1562

* Renamed kind in CRDs
* Renamed KameletBinding examples by changing suffix -binding to -pipe
* Renamed folder and file names having binding
* Updated doc
* Updated Yaks tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>

* Fix YAKS test aws-s3-to-http

camel:cloudevents dependency is required because the pipe uses the CloudEvents data type transformers from Camel

---------

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Co-authored-by: Christoph Deppisch <cdeppisch@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apupier apupier

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@davsclaus @claudio4j @apupier @oscerd