Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare implicit dependencies #214

Closed
lburgazzoli opened this issue May 4, 2021 · 3 comments
Closed

Declare implicit dependencies #214

lburgazzoli opened this issue May 4, 2021 · 3 comments
Assignees

Comments

@lburgazzoli
Copy link
Contributor

When it is about dependencies, the documentation states:

The Kamelet MAY declare dependencies on Camel components using the syntax camel:<component-name> 
(e.g. camel:telegram). Some Camel dependencies are implicitly added by the runtime when a certain Camel 
URI is used (e.g. there's no need to declare explicit dependency on camel:timer if the flow section uses the
timer URI).

This works fine for camel-k but in order to leverage the kamelets capabilities across different runtimes, i.e. camel-quarkus and camel-kafka-connect, it would be better if all the dependencies were explicitly listed.

@lburgazzoli
Copy link
Contributor Author

/cc @valdar

@valdar valdar self-assigned this May 4, 2021
@nicolaferraro
Copy link
Member

I think we can also use kamel (or kamel bits) to auto-detect / auto-enhance the catalog

@valdar
Copy link
Member

valdar commented May 4, 2021

@nicolaferraro I will look into that, my initial idea was to:

  1. add that detection of the missing implicit dependencies to the script/validator
  2. initially make it fail validation hinting which dependencies to add.
  3. add the call to validator to the "local build" through mvn clean install

valdar added a commit to valdar/camel-kamelets that referenced this issue May 7, 2021
related to apache#214 : Declare implicit dependencies
valdar added a commit to valdar/camel-kamelets that referenced this issue May 7, 2021
oscerd pushed a commit that referenced this issue May 7, 2021
related to #214 : Declare implicit dependencies
@oscerd oscerd closed this as completed in 77610f1 May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants