Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Kamelets Catalog to throw IOException #225

Closed
apupier opened this issue May 4, 2021 · 2 comments
Closed

Avoid Kamelets Catalog to throw IOException #225

apupier opened this issue May 4, 2021 · 2 comments
Assignees
@oscerd

Comments

@apupier
Copy link
Contributor

apupier commented May 4, 2021

It woudl be more convenient when using it.

I think it is reasonable that the list of kamelets is empty in the catalog in case of IOException
@oscerd oscerd self-assigned this May 4, 2021
@oscerd
Copy link
Contributor

oscerd commented May 4, 2021

Sounds good. If you have time and will, it would be good to have a pr

@apupier
Copy link
Contributor Author

apupier commented May 4, 2021

I can have a look at it

apupier added a commit to apupier/camel-kamelets that referenced this issue May 4, 2021
@apupier
Avoid IOException on constructor apache#225
a680585 
- when a kamelet file cannot be loaded, a log is provided but other
files still can load
- provided a test to ensure that we are not embedding some kamelet files
that are invalid and that we won't detect anymore with existing tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue May 4, 2021
@apupier
Avoid IOException on constructor apache#225
62a34a0 
- when a kamelet file cannot be loaded, a log is provided but other
files still can load
- provided a test to ensure that we are not embedding some kamelet files
that are invalid and that we won't detect anymore with existing tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue May 4, 2021
@apupier
Avoid IOException on constructor apache#225
92e42bc 
- when a kamelet file cannot be loaded, a log is provided but other
files still can load
- provided a test to ensure that we are not embedding some kamelet files
that are invalid and that we won't detect anymore with existing tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue May 4, 2021
@apupier
Avoid IOException on constructor apache#225
3950b50 
- when a kamelet file cannot be loaded, a log is provided but other
files still can load
- provided a test to ensure that we are not embedding some kamelet files
that are invalid and that we won't detect anymore with existing tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-kamelets that referenced this issue May 4, 2021
@apupier
Avoid IOException on constructor apache#225
d640503 
- when a kamelet file cannot be loaded, a log is provided but other
files still can load
- provided a test to ensure that we are not embedding some kamelet files
that are invalid and that we won't detect anymore with existing tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@oscerd oscerd mentioned this issue May 4, 2021
Merged
oscerd pushed a commit that referenced this issue May 4, 2021
@apupier @oscerd
Avoid IOException on constructor #225
4e4bae2 
- when a kamelet file cannot be loaded, a log is provided but other
files still can load
- provided a test to ensure that we are not embedding some kamelet files
that are invalid and that we won't detect anymore with existing tests

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscerd oscerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apupier @oscerd