-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding filter for exluding explicit content to chuck-norris-source #511
Comments
I just see, that there is a field "explicit" in the jokes, so maybe better filter on that (and possibly allow an option for the sink to also allow explicit jokes) |
{ "type": "success", "value": { "id": 71, "joke": "....", "categories": ["explicit"] } } |
Yeah, there's also a filter in the URL, like: http://api.icndb.com/jokes/random?limitTo=[,nerdy] If you just change that in the kamelet definition of your demo you should filter out explicit stuff. We may also add an option in the Kamelet to toggle them. |
It would be cool, to allow a 'safe' set by default and only enable explicit things if, well, explicitly requested :). Also, if you set a category you also filter out all quotes without a category (which most of them are) |
I think http://api.icndb.com/jokes/random?exclude=[explicit] is it ... |
A future extension could add a parameter to re-enable explicite qoutes, but for now I think it is safer to disable to avoid offending people when using the source in demos. Fixes apache#511.
A future extension could add a parameter to re-enable explicite qoutes, but for now I think it is safer to disable to avoid offending people when using the source in demos. Fixes #511.
I love the chuck-norris-source, and would like to use them in demos, but a bit afraid of showing up a quote like in https://api.chucknorris.io/jokes/7xoo4cjutwu3sgmuelp2pw during a customer demo ;-P While not necessarily not funny, it might confuse the audience a bit.
Would it be possible to add a filter from a bad-word list to
camel-kamelets/chuck-norris-source.kamelet.yaml
Lines 39 to 42 in fb004b9
The text was updated successfully, but these errors were encountered: