Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telegram-sink chat-id property must be required and/or have a default? #981

Closed
valdar opened this issue Jul 25, 2022 · 2 comments
Closed

telegram-sink chat-id property must be required and/or have a default? #981

valdar opened this issue Jul 25, 2022 · 2 comments

Comments

@valdar
Copy link
Member

valdar commented Jul 25, 2022

I think that the chat id property in telegram-sink kamelet should be required, or if left optional provided with a default? otherwise the resulting deployed kamelet dose not even start.

I personally think that a default value does not make much sense. I would vote for making it required.
@oscerd
Copy link
Contributor

oscerd commented Jul 25, 2022

Please open a PR

@manstis manstis mentioned this issue Feb 23, 2023
Merged
@manstis
Copy link

manstis commented Feb 23, 2023

See #1305

@oscerd oscerd closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valdar @manstis @oscerd