Issue-981: Improve narrative for chatId. #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Feb 23, 2023
|
Needs to be backported on 3.x and 3.20.x too. |
This was referenced Feb 23, 2023
|
@oscerd I've been thinking on this... This PR made I'm thinking it may have been better to simply improve the description to read along the lines of WDYT? Happy to submit more PRs. |
|
This is on main branch, so a breaking change is fine. I'm happy to merge more stuff if you feel it would be better to just add a description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #981
The consensus was that the documentation wasn't entirely clear as to whether
chatIdwas mandatory or not.It is mandatory but not necessarily as a Configuration Option if provided in the header.