Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS S3 Sink Kamelet #107

Merged
merged 1 commit into from
Apr 7, 2021
Merged

AWS S3 Sink Kamelet #107

merged 1 commit into from
Apr 7, 2021

Conversation

claudio4j
Copy link
Contributor

@claudio4j claudio4j commented Mar 30, 2021

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should follow the approach we use in dropbox sink: https://github.com/apache/camel-kamelets/blob/master/dropbox-sink.kamelet.yaml#L51

And state in the description that the sink expects the header to be set.

@claudio4j
Copy link
Contributor Author

In camel-dropbox if there is no header to designate the filename, it uses the exchange id, but in camel-aws2-s3 there is no such default for filename. So, in this case I think requiring the filename is appropriate isn't ? Or should we set the exchange id if there is no CamelAwsS3Key header ?

@oscerd
Copy link
Contributor

oscerd commented Mar 30, 2021

In camel-dropbox if there is no header to designate the filename, it uses the exchange id, but in camel-aws2-s3 there is no such default for filename. So, in this case I think requiring the filename is appropriate isn't ? Or should we set the exchange id if there is no CamelAwsS3Key header ?

I meant to say the same style as dropbox, by adding an otherwise step to set the header as exchange id. Like in the minio sink connector for example: https://github.com/apache/camel-kamelets/blob/master/minio-sink.kamelet.yaml#L60

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little thing.

aws-s3-sink.kamelet.yaml Outdated Show resolved Hide resolved
@nicolaferraro nicolaferraro merged commit 23b509b into apache:master Apr 7, 2021
@claudio4j claudio4j deleted the add_s3_sink branch April 7, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants