Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AWS2-S3 source kamelet #11

Merged
merged 2 commits into from Feb 17, 2021
Merged

Added AWS2-S3 source kamelet #11

merged 2 commits into from Feb 17, 2021

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Feb 16, 2021

Fixes #10

@oscerd
Copy link
Contributor Author

oscerd commented Feb 16, 2021

cc @nicolaferraro

@nicolaferraro
Copy link
Member

nicolaferraro commented Feb 17, 2021 •
edited

I think we can stick to one version of the Kamelet here, so I'd remove the existing aws-s3-source and rename this. It was copied from an existing example, but there seems there's no reasons to maintain both here, unless they add something from a connector end-user perspective. Wdyt @oscerd ? The Kamelet seems ok.

@oscerd
Copy link
Contributor Author

oscerd commented Feb 17, 2021

Sure I can do that in a subsequent pr

@oscerd oscerd force-pushed the aws2-s3 branch 2 times, most recently from 39b0b63 to c7ec5fb Compare February 17, 2021 12:07
@oscerd
Copy link
Contributor Author

oscerd commented Feb 17, 2021

@nicolaferraro updated

@nicolaferraro nicolaferraro merged commit a4cf1d3 into master Feb 17, 2021
@oscerd oscerd deleted the aws2-s3 branch February 18, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AWS2-S3 source kamelet
2 participants
@oscerd @nicolaferraro