Slack Sink: iconEmoji, iconUrl, username are deprecated in camel #1329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please advise if you require Camel issues lodged for PRs vs third party tracking references.
The underlying Slack Component has deprecated a few parameters, namely
iconEmoji
,iconUrl
andusername
.This PR attempts to reflect the same in the corresponding Kamelet definition.
I'm uncertain if Kamelets even support the definition of deprecated parameters. Documentation isn't clear.
I'm even less clear, to be honest, whether the
parameters
in a Kamelet map to "Components Options" or "Query parameters" or both due to some clever name-based mapping in Camel. The three affected Kamelet parameters appear asparameters
in the Kamelet but as "Query parameters" in the Component. The Kamelet parameterwebhookUrl
relates to a Component Option and Query parameter.I suspect they only map to Component Options and hence the three "Query" parameters can be removed entirely and not just deprecated.
Advice welcome.