Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack Sink: iconEmoji, iconUrl, username are deprecated in camel #1329

Closed
wants to merge 1 commit into from

Conversation

manstis
Copy link

@manstis manstis commented Mar 2, 2023

Please advise if you require Camel issues lodged for PRs vs third party tracking references.

The underlying Slack Component has deprecated a few parameters, namely iconEmoji, iconUrl and username.

This PR attempts to reflect the same in the corresponding Kamelet definition.

I'm uncertain if Kamelets even support the definition of deprecated parameters. Documentation isn't clear.

I'm even less clear, to be honest, whether the parameters in a Kamelet map to "Components Options" or "Query parameters" or both due to some clever name-based mapping in Camel. The three affected Kamelet parameters appear as parameters in the Kamelet but as "Query parameters" in the Component. The Kamelet parameter webhookUrl relates to a Component Option and Query parameter.

I suspect they only map to Component Options and hence the three "Query" parameters can be removed entirely and not just deprecated.

Advice welcome.

@oscerd
Copy link
Contributor

oscerd commented Mar 2, 2023

Please don't use downstream JIRA. For the upstream there is no point in linking them. This is the upstream and we should focus on upstream only. I edited the text

@oscerd oscerd changed the title MGDCTRS-1899: Slack Sink: iconEmoji, iconUrl, username are deprecated in camel Slack Sink: iconEmoji, iconUrl, username are deprecated in camel Mar 2, 2023
@manstis
Copy link
Author

manstis commented Mar 2, 2023

Closing in lieu of #1330

Whatever solution is agreed will need to be enacted for this Slack Sink.

@manstis manstis closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants