Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-1336: DynamoDB Sink - use enum for available operations #1337

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Issue-1336: DynamoDB Sink - use enum for available operations #1337

merged 2 commits into from
Mar 3, 2023

Conversation

manstis
Copy link

@manstis manstis commented Mar 3, 2023

See #1336

@manstis manstis mentioned this pull request Mar 3, 2023
Closed
@manstis
Copy link
Author

manstis commented Mar 3, 2023

The Build / build and Java Tests steps fail as an additional Kamelet for aws-ddb-experimental-sink was generated.

I can either remove this experimental Kamelet from the PR (as it does not exist on main) or should the test be updated?

I didn't manually add the Kamelet it was generated (presumably missed/skipped previously?)

@oscerd
Copy link
Contributor

oscerd commented Mar 3, 2023

The experimental kamelets has been removed already. Please rebase

oscerd
oscerd requested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor finding

kamelets/aws-ddb-sink.kamelet.yaml Outdated Show resolved Hide resolved
kamelets/aws-ddb-sink.kamelet.yaml Outdated Show resolved Hide resolved
@oscerd
Copy link
Contributor

oscerd commented Mar 3, 2023

Thanks for this.

@oscerd
Copy link
Contributor

oscerd commented Mar 3, 2023

I do think this should be backported on 3.x and 3.20.x too, but mind that there is the experimental one there. Thanks.

@oscerd oscerd merged commit 8d0da4a into apache:main Mar 3, 2023
This was referenced Mar 6, 2023
Merged
Merged
@manstis
Copy link
Author

manstis commented Mar 6, 2023

@oscerd

I do think this should be backported on 3.x and 3.20.x too, but mind that there is the experimental one there. Thanks.

This was referenced Mar 6, 2023
Merged
Merged
@oscerd oscerd modified the milestones: 3.20.2, 3.21.0 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.21.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manstis @oscerd