JMS AMQP 1.0 Source/Sink Kamelets: Replace QPID client with camel-amqp #1378
Conversation
|
Additional note : I don't need the camel-jms component since it is a dependency from camel-amqp. When removing it the validate script fails because it is not present anymore in dependencies. |
|
I think the validation must be reviewed at all also I do think we don't think the qpid-jms-client in the bom, since it's not managed anymore now. |
Ha you are right, I will remove the QPID client everywhere it needs to be. |
gansheer
force-pushed
the
fix/jms_amqp_source_sink
branch
from
2202c4b
to
4f08a8a
Compare
|
@gansheer I'm just curious that
Is it Quarkus native mode? If it is, I think we need to use |
…qp kamelets * The client qpid does not works in native mode (stacktrace log `Caused by: java.lang.ClassNotFoundException: org.apache.qpid.jms.JmsConnectionFactory`) * the camel-amqp component is designed for this case : supporting the AMQP 1.0 protocol through the JMS QPID Client.
gansheer
force-pushed
the
fix/jms_amqp_source_sink
branch
from
4f08a8a
to
87315f2
Compare
Kamelets are not designed to work only with quarkus as runtime, it was like that in the beginning, so I don't think it's the case to add a quarkus dependency directly in the yaml. |
|
@zhfeng I am talking about the library "mvn:org.apache.qpid:qpid-jms-client:1.0.0". |
|
I get it and thanks for your clarifying. |
|
This could be backported to 3.x and also to 3.20.x |
Motivation
The client qpid dependency does not works in native mode (stacktrace log
Caused by: java.lang.ClassNotFoundException: org.apache.qpid.jms.JmsConnectionFactory).Description
The camel-amqp component is designed for the kamelets use case : supporting the AMQP 1.0 protocol through the JMS QPID Client. So replacing the client dependency by the component makes sense.
Note
Will probably need some backports