Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Data Type Transformer API provided by Camel 4.0 #1607

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

christophd
Copy link
Contributor

@christophd christophd commented Aug 31, 2023

  • Camel 4.0 introduces a data type support based on the transformer API. Use this instead of the interim implementation in utils
  • Remove data type transformers that are now provided by Camel core
  • Remove interim data type processor implementation in this repository and use data type processor implementation provided by Camel 4
  • Refactor data type action Kamelet to use new Camel 4 data type processor
  • Keep those data type transformer implementations (Avro, Json Struct, ...) that have not been ported to Camel core yet
  • Update to YAKS 0.16.0 as it allows to explicitly set the camel-kamelets version in Camel JBang
  • Update aws-ddb-sink Kamelet to use new data type transform API

@christophd christophd force-pushed the chore/camel-4-data-type-transformer branch from cbfa99a to 542ffb5 Compare August 31, 2023 15:12
@claudio4j
Copy link
Contributor

The implementation and kamelets are more clear and concise to use.

@christophd christophd force-pushed the chore/camel-4-data-type-transformer branch 5 times, most recently from 6980202 to e928da3 Compare August 31, 2023 19:34
- Camel 4.0 introduces a data type support based on the transformer API. Use this instead of the interim implementation in utils
- Remove data type transformers that are now provided by Camel core
- Remove interim data type processor implementation in this repository and use data type processor implementation provided by Camel 4
- Refactor data type action Kamelet to use new Camel 4 data type processor
- Keep those data type transformer implementations (Avro, Json Struct, ...) that have not been ported to Camel core yet
- Update to YAKS 0.16.0 as it allows to explicitly set the camel-kamelets version in Camel JBang
- Update aws-ddb-sink Kamelet to use new data type transform API
@christophd christophd force-pushed the chore/camel-4-data-type-transformer branch from e928da3 to ab2aec9 Compare August 31, 2023 19:55
@christophd
Copy link
Contributor Author

YAY, tests are green!

@claudio4j thank you! Yes I really like the new way to use transform EIP in combination with data types:

from:
  uri: "kamelet:source"
  steps:
  - transform:
      to-type: "aws2-ddb:application-json"
  - to:
      uri: "aws2-ddb:{{table}}"

Also the built-in data type support on Kamelet source/sink makes it easy to use it in a pipe/binding:

kind: KameletBinding
metadata:
  name: aws-s3-to-http
spec:
  source:
    ref:
      kind: Kamelet
      apiVersion: camel.apache.org/v1alpha1
      name: aws-s3-source
    properties:
      # ...
    dataTypes:
      out:
        format: "aws2-s3:application-cloudevents"

@oscerd oscerd merged commit 55462b6 into apache:main Sep 1, 2023
5 checks passed
@oscerd
Copy link
Contributor

oscerd commented Sep 1, 2023

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants