Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS IP Action #170

Merged
merged 5 commits into from
Apr 26, 2021
Merged

DNS IP Action #170

merged 5 commits into from
Apr 26, 2021

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Apr 26, 2021

Related to #168

nicolaferraro
nicolaferraro reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this modifies the body, can we also fallback to using the body as source ip when the domain header is not present? This way it can be used as simple body transformation from DNS to ip, like a "resolve action". Wdyt?

@nicolaferraro nicolaferraro merged commit a92c48d into main Apr 26, 2021
@valdar valdar deleted the dns-ip branch May 4, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscerd @nicolaferraro