Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElasticSearch search source kamelet #172

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Conversation

Delawen
Copy link
Contributor

@Delawen Delawen commented Apr 26, 2021

Ready to review.

@Delawen
Copy link
Contributor Author

Delawen commented Apr 26, 2021

The output is of type org.elasticsearch.search.SearchHits. Is that fine or should I try to "normalize" this to something standard like a String with a JSON?

[1] 2021-04-26 10:56:34,456 INFO [info] (Camel (camel-1) thread #0 - timer://tick) Exchange[ExchangePattern: InOnly, BodyType: org.elasticsearch.search.SearchHits, Body: org.elasticsearch.search.SearchHits@393ceaa3]

@Delawen Delawen marked this pull request as ready for review April 26, 2021 11:49
@oscerd
Copy link
Contributor

oscerd commented Apr 26, 2021

Json would be better.

@Delawen
Copy link
Contributor Author

Delawen commented Apr 26, 2021

I don't think I can do proper yaks testing against an ElasticSearch.

I am testing that queries like the following work fine with my own ElasticSearch:

kamel bind "elasticsearch-search-source?clusterName=quickstart&hostAddresses=quickstart-es-http:9200&user=elastic&password=3n766wE6tg1K4uL1m8or4CqB&query=%7B%22query%22:%7B%22match%22:%7B%22test%22:%22123%22%7D%20%7D%20%7D&indexName=data&enableSSL=false" log:info; 
kamel logs elasticsearch-search-source-to-log

@nicolaferraro
Copy link
Member

Cool, thanks

@nicolaferraro nicolaferraro merged commit 465e1ba into apache:main Apr 26, 2021
@Delawen Delawen deleted the elasticsearch branch April 26, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants