-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generate the Kamelet Catalog website #2
Conversation
We need @zregvart for including this somewhere in the website. |
random thought:
|
Yeah, so versioning can be done by tagging this repo as per proposal. Antora supports multiple versions oob. There's a |
I'm not sure if it makes sense to have the same ui we are using on the camel website, just for visual identity, btw we need @zregvart to include it. |
Yeah, this includes a custom UI with additional CSS and layout on top of the Antora default one, but it's a temporary solution until we embed the camel default UI. I'd like adding the "catalog" layout to the main Camel UI and the best would be to have it published in an HTTP location (maybe using Github actions, like the Antora folks seem to do), so that we can reference it back from here in: camel-kamelets/docs/antora-playbook.yml Line 15 in 15165a7
Is it possible @zregvart ? |
I was more thinking about kamelet specific versions, giving that they can be used even without a catalog, whould we also let people browse to a specific kamelet version ?
+1 for making group mandatory |
@nicolaferraro perhaps you can start a pull request with the changes needed to the website on the website repository. Not sure what's to gain by adding those changes here. Is the end goal to publish to a different domain? |
No, it's only for the Camel website, I did them here just to have a quick preview in dev + I want later to integrate Netlify on PR.. but the code is well separated so the plan was to move it to the camel-website from the beginning. I'll try to publish the layout there, and also the final bundle so I can link it from here (if possible with the new Apache rules for Githu Actions...) |
Gorgeous 👏🏼! |
If at all possible do not add another UI bundle to the camel-website, there are a number of optimizations that went into the apache-camel-ui UI bundle in the camel-website repository that you'll need to repeat in the second bundle. Adding changes to the existing apache-camel-ui UI bundle should be preferred. This also maintains the separation of presentation vs content we have between the camel-website and other git repositories we pull to build the website. Not sure about the Netlify integration, this is already present on the camel-website repository. If you wish trigger publishing of changes made here to the website, that needs to happen with the trigger to the Camel.website job on the ASF Jenkins. Automating that could be done via a generic webhook on push to this repository (would require a secret to be added by INFRA). |
It wasn't my intention.. I kept changes separated into a bunch of files to merge them: apache/camel-website#536 I managed to display this catalog with the website UI with that change: |
I'd like to polish this a bit, either as a PR on top of this PR (preferred) or as a followup PR. |
You're welcome to do so. Look also at apache/camel-website#537 to completely remove the custom UI from here. |
I've created a PR to polish this against this PR: nicolaferraro#1 |
Using `indexBlock` extension we can add content to `index.adoc` from all pages in the component.
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Let's merge this to unlock: apache/camel-website#536 |
We now have the basis of a Antora component in apache/camel-kamelets[1] so we can switch to that. [1] apache/camel-kamelets#2
We now have the basis of a Antora component in apache/camel-kamelets[1] so we can switch to that. [1] apache/camel-kamelets#2
We now have the basis of a Antora component in apache/camel-kamelets[1] so we can switch to that. [1] apache/camel-kamelets#2
This generates an Antora module for the Kamelet catalog directly from the Kamelet YAML files.
cc: @davsclaus , @oscerd , @astefanutti , @squakez , @doru1004 , @lburgazzoli, @christophd
A preview...
Next step for the UI: