Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMQP JMS source kamelet #362

Merged
merged 1 commit into from Jun 15, 2021
Merged

AMQP JMS source kamelet #362

merged 1 commit into from Jun 15, 2021

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Jun 14, 2021

No description provided.

@orpiske orpiske marked this pull request as draft June 14, 2021 10:24
oscerd
oscerd requested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be ok, but we need to use the same naming convention.

Also, run mvn clean install, so it will be added to catalog.

And after that have a look at script/generator to generate docs and script/validate to validate.

@orpiske
Copy link
Contributor Author

orpiske commented Jun 14, 2021 •
edited

@oscerd one problem that I foresee with this one is that it does not have a free icon available. If we enforce the MUST have camel.apache.org/kamelet.icon annotation, this one might be delayed until we clear this out or come up with an icon for it.

More especifically: the group developing the AMQP 1.0 protocol, does not seem to make available a free icon to use. I'll check around with some contacts, but it may not be guaranteed we'll have one.

@oscerd
Copy link
Contributor

oscerd commented Jun 14, 2021

You can use any icon related to messaging, it shouldn't be a logo or something related to amqp. So even a message icon is fine.

@orpiske
Copy link
Contributor Author

orpiske commented Jun 14, 2021 •
edited

You can use any icon related to messaging, it shouldn't be a logo or something related to amqp. So even a message icon is fine.

That helps. Let's use the QPid one. Thanks!

@orpiske orpiske force-pushed the amqp-jms-source branch 2 times, most recently from cb08808 to d14f2c9 Compare June 14, 2021 13:14
@orpiske orpiske marked this pull request as ready for review June 14, 2021 13:15
oscerd
oscerd approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nicolaferraro

@nicolaferraro nicolaferraro merged commit b8c7cfb into apache:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orpiske @oscerd @nicolaferraro